• 0 Posts
  • 97 Comments
Joined 1 year ago
cake
Cake day: June 22nd, 2023

help-circle

  • wewbull@feddit.uktoPython@programming.devNumPy 2.0.0 released
    link
    fedilink
    English
    arrow-up
    19
    arrow-down
    2
    ·
    14 days ago

    Furthermore there are many changes to NumPy internals, including continuing to migrate code from C to C++, that will make it easier to improve and maintain NumPy in the future.

    I realise that C can be rather low level a lot of the time, but I’m not sure I’d pick C++ to help keep things easy to maintain. It opens up a Pandora’s box of possibilities.












  • Not high. It tends to result in one of a few things.

    1. They take the fix as offered. Probably it’s a smaller quiet project where the number of PRs is small. That, or very well run.

    2. It remains forever open and gets lost in the masses of other out of date PRs. Maybe a bot comes along and closes it as stale. Biggest group, and these ones just tell me that I’ve got very little chance of getting the maintainer’s attention. I can see that 100s of others have experienced the same fate.

    3. Somebody else finds it useful and adopts it, fighting for it to go in. Sometimes that someone is the maintainer. As you say, it can be inspiration for a rewrite of my contribution. That’s fine by me. Whatever works.

    4. The maintainer makes a bunch of rework demands leading to rejection, or it gets rejected straight off. “My way or the highway” is always going to be highway. I offered a small piece of help, and if it’s not wanted I’ll happily go away.

    Maybe 20% get in, but it depends on so many things.


  • Honestly, I run and gun. I make the change I want, and submit a merge request. I then move on. It’s then up to the maintainer to accept or reject it.

    I’m not going to debate it. I’m not going to rework it over the course of months to make it perfect in the maintainer’s eyes. I don’t care enough about it. I’ve solved my problem. I’m just sharing it for others.

    The things I submit are normally big fixes with the smallest possible code change, not refactorings to solve an underlying problem.